Skip to content

ci: provide ways to limit the number of "e2e tests" runs#3197

Merged
tbouffard merged 6 commits into
masterfrom
ci/disable_e2e_wf_with_label
Oct 28, 2024
Merged

ci: provide ways to limit the number of "e2e tests" runs#3197
tbouffard merged 6 commits into
masterfrom
ci/disable_e2e_wf_with_label

Conversation

@tbouffard

Copy link
Copy Markdown
Member

The e2e workflow currently runs 11 jobs. Since the GitHub organization allows a maximum of 20 concurrent jobs (with only 5 runners for macOS), it is essential to limit unnecessary runs.

This is particularly important when drafting a PR, as running these tests can often be deferred and re-enabled later. For example, temporarily disabling e2e tests during the drafting phase and re-enabling them later without committing configuration changes (e.g., removing or editing the workflow file) helps to significantly reduce redundant runs.

Implemented Improvements

  • Concurrency Control: Automatically stop workflows for older commits when multiple commits are pushed in quick succession, ensuring that only the latest commit triggers the workflow.
  • Skip on Demand: Enable skipping workflow runs by setting a specific label on the PR.

Notes

Closes #2172
Will be improved by #3196

The e2e workflow currently runs 11 jobs. Since the GitHub organization allows a maximum of 20 concurrent jobs (with only 5 runners for macOS), it is essential to limit unnecessary runs.

This is particularly important when drafting a PR, as running these tests can often be deferred and re-enabled later. For example, temporarily disabling e2e tests during the drafting phase and re-enabling them later without committing configuration changes (e.g., removing or editing the workflow file) helps to significantly reduce redundant runs.

Implemented Improvements
  - Concurrency Control: Automatically stop workflows for older commits when multiple commits are pushed in quick succession, ensuring that only the latest commit triggers the workflow.
  - Skip on Demand: Enable skipping workflow runs by setting a specific label on the PR.
@tbouffard tbouffard added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) skip CI e2e tests GitHub Actions do not run e2e tests (for Pull Requests) labels Oct 21, 2024
@tbouffard

tbouffard commented Oct 21, 2024

Copy link
Copy Markdown
Member Author

❌ The e2e tests workflow is currently invalid
https://github.com/process-analytics/bpmn-visualization-js/actions/runs/11441484769
You have an error in your yaml syntax on line 50

✔️ workflow syntax OK thanks to b3ce5c3.
The workflow is not started when the label is set: https://github.com/process-analytics/bpmn-visualization-js/actions/runs/11442229642?pr=3197

image

✔️ Concurrency group configuration

image

@tbouffard tbouffard removed the skip CI e2e tests GitHub Actions do not run e2e tests (for Pull Requests) label Oct 21, 2024
@tbouffard tbouffard marked this pull request as ready for review October 21, 2024 14:35
@tbouffard tbouffard requested a review from csouchet October 21, 2024 14:35
@tbouffard tbouffard added the skip CI e2e tests GitHub Actions do not run e2e tests (for Pull Requests) label Oct 28, 2024
@tbouffard tbouffard changed the title ci: provide ways to limit the number of "e2e tests" workflow runs ci: provide ways to limit the number of "e2e tests" runs Oct 28, 2024
@tbouffard tbouffard merged commit 027dfea into master Oct 28, 2024
@tbouffard tbouffard deleted the ci/disable_e2e_wf_with_label branch October 28, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) skip CI e2e tests GitHub Actions do not run e2e tests (for Pull Requests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[INFRA] Reduce the number of GitHub job runs

2 participants