fix: remove extra spacing between 2 activity markers#3052
Merged
Conversation
When there are 2 markers, the center was translated/shifted too much. We assume that the width value of markers is `SHAPE_ACTIVITY_MARKER_ICON_SIZE`. We want to have a spacing value between the 2 markers of `SHAPE_ACTIVITY_MARKER_ICON_MARGIN`. To have 2 markers horizontally centered and closed to each other, we need to translate the first marker to the left and the second to the right by half the value of the marker width. To add a space between the 2 markers, we need to translate both markers by half the value of the global "spacing value". Previously, the translation value included the full marker width which is too much. Also include refactoring: - Use more accurate name for the parameters of `getMarkerIconOriginFunction`.
|
♻️ PR Preview 14b68ef has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 14b68ef has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
30 tasks
csouchet
approved these changes
Mar 7, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are 2 markers, the center was translated/shifted too much. We assume that the width value of markers is
SHAPE_ACTIVITY_MARKER_ICON_SIZE. We want to have a spacing value between the 2 markers ofSHAPE_ACTIVITY_MARKER_ICON_MARGIN.To have 2 markers horizontally centered and closed to each other, we need to translate the first marker to the left and the second to the right by half the value of the marker width. To add a space between the 2 markers, we need to translate both markers by half the value of the global "spacing value". Previously, the translation value included the full marker width which is too much.
Also include refactoring:
getMarkerIconOriginFunction.Notes
Covers #992
Detected as part of #2724
Additional information
The implementation to generalize markers positioning for 3 and more markers experimented in #2724 uses the same logic as the fix proposed here.
Here are explanations taken from #2724: