chore: enforce no unused parameters and locals with TypeScript#3051
Merged
Conversation
Fix new TS compiler errors: remove or prefix (when must be kept to override methods) parameters, remove unused class properties. Group "noXXX" TypeScript compiler options.
tbouffard
added
the
chore
|
♻️ PR Preview f2e84d9 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview f2e84d9 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
Mark unused param in test function. They must be kept as the parameter is used to generate the test title or because it is required by the function signature.
|
csouchet
approved these changes
Mar 7, 2024
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix new TS compiler errors: remove or prefix (when must be kept to override methods) parameters, remove unused class properties.
Unit tests: mark unused parameters in test function.
They must be kept as the parameter is used to generate the test title or because it is required by the function signature.
Group "noXXX" TypeScript compiler options.
Notes
This has been detected during investigations done in of #2724.