refactor!: remove BpmnCanvas.setIconOriginForIconOnBottomLeft#3050
Merged
tbouffard merged 1 commit intoMar 6, 2024
Merged
Conversation
In addition, remove StyleDefault.SHAPE_ACTIVITY_FROM_CENTER_MARGIN that was only used in this method. The StyleDefault value was only used in the removed method. BREAKING CHANGES: remove unused elements - BpmnCanvas.setIconOriginForIconOnBottomLeft - StyleDefault.SHAPE_ACTIVITY_FROM_CENTER_MARGIN There should be no impact for users of bpmn-visualization as there is no reason to use this former method. No existing repository of the Process Analytics project was using it.
|
♻️ PR Preview 248141f has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 248141f has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
tbouffard
changed the title
BpmnCanvas.setIconOriginForIconOnBottomLeftBpmnCanvas.setIconOriginForIconOnBottomLeft
csouchet
approved these changes
Mar 6, 2024
tbouffard
deleted the
refactor/remove_BpmnCanvas.setIconOriginForIconOnBottomLeft
branch
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This former method is no longer used.
In addition, remove
StyleDefault.SHAPE_ACTIVITY_FROM_CENTER_MARGINthat was only used in this method.The
StyleDefaultvalue was only used in the removed method.BREAKING CHANGES: remove unused elements
BpmnCanvas.setIconOriginForIconOnBottomLeftStyleDefault.SHAPE_ACTIVITY_FROM_CENTER_MARGINThere should be no impact for users of bpmn-visualization as there is no reason to use this former method. No existing repository of the Process Analytics project was using it.
Notes
I checked the whole PA repositories with the GitHub search, and I found no reference to the removed elements.
Detected during investigations of #2724.