Skip to content

docs: improve JSDoc of PaintParameter and StyleDefault#3049

Merged
tbouffard merged 2 commits into
masterfrom
docs/improve_jsdoc_StyleDefault_PaintParameter
Mar 25, 2024
Merged

docs: improve JSDoc of PaintParameter and StyleDefault#3049
tbouffard merged 2 commits into
masterfrom
docs/improve_jsdoc_StyleDefault_PaintParameter

Conversation

@tbouffard

Copy link
Copy Markdown
Member

Document the purpose of some properties in StyleDefault related to activity icons and markers.

Notes

This improvement has been detected during investigations done in of #2724.

@tbouffard tbouffard added the documentation Improvements or additions to documentation label Mar 4, 2024
@github-actions

github-actions Bot commented Mar 4, 2024

Copy link
Copy Markdown

🎊 PR Preview 2060e06 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3049.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

@github-actions

github-actions Bot commented Mar 4, 2024

Copy link
Copy Markdown

🎊 PR Preview 2060e06 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3049.surge.sh

🕐 Build time: 0.011s

🤖 By surge-preview

Comment thread src/component/mxgraph/shape/render/icon-painter.ts Outdated
Comment thread src/component/mxgraph/shape/render/icon-painter.ts Outdated
Comment thread src/component/mxgraph/style/utils.ts Outdated
Document the purpose of some properties in StyleDefault related to activity icons and markers.
@tbouffard tbouffard force-pushed the docs/improve_jsdoc_StyleDefault_PaintParameter branch from cd1ec1b to 2060e06 Compare March 25, 2024 11:16
@tbouffard tbouffard marked this pull request as ready for review March 25, 2024 11:16
@tbouffard tbouffard requested a review from csouchet March 25, 2024 11:16
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tbouffard tbouffard merged commit e0a9a80 into master Mar 25, 2024
@tbouffard tbouffard deleted the docs/improve_jsdoc_StyleDefault_PaintParameter branch March 25, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants