refactor: directly override svgCanvas2D.getTextCss#3046
Merged
tbouffard merged 3 commits intoMar 4, 2024
Conversation
Previously, this was done by modifying the svgCanvas2D prototype. The new implementation limits side effects on applications that use mxGraph directly, and don't modify code the lib doesn't own. The mxGraph implementation overriding is required to ensure that the label pointer-events is set to 'none'. New integration tests have been added to validate the old behavior and ensure that the refactoring has preserved it. In particular, more tests check the labels of a greater number of BPMN element types, and the value of the "pointer-events" property of labels is explicitly checked. The overriding implementation has been simplified to reduce the copy/paste of mxGraph code. Instead, it now calls the standard mxGraph implementation with specific settings.
|
♻️ PR Preview 79996cd has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 79996cd has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
tbouffard
commented
Mar 1, 2024
[skip ci]
|
csouchet
approved these changes
Mar 4, 2024
tbouffard
deleted the
refactor/no_mxSvgCanvas2D.getTextCss_prototype_override
branch
This was referenced Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this was done by modifying the
mxSvgCanvas2Dprototype. The new implementation limits side effects on applications that usemxGraphdirectly, and doesn't modify code the lib doesn't own.The
mxGraphimplementation overriding is required to ensure that the label pointer-events is set to 'none'. New integration tests have been added to validate the old behavior and ensure that the refactoring has preserved it. In particular, more tests check the labels of a greater number of BPMN element types, and the value of the "pointer-events" property of labels is explicitly checked.The overriding implementation has been simplified to reduce the copy/paste of
mxGraphcode. Instead, it now calls the standardmxGraphimplementation with specific settings.Notes
Continue the work started in #3043.