refactor: use internal functions rather than static private methods#3041
Merged
tbouffard merged 2 commits intoMar 1, 2024
Merged
Conversation
Replace pure private static methods (i.e. method not using static property) by functions to better encapsulate the implementation logic. Such methods are generated as public in the JavaScript code which is not needed.
|
♻️ PR Preview b940060 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview b940060 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
tbouffard
changed the title
csouchet
approved these changes
Feb 26, 2024
|
This was referenced Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace pure private static methods (i.e. method not using static property) by functions to better encapsulate the implementation logic.
These methods are generated as public in the JavaScript code, which is not necessary.