Skip to content

chore(demo): bump fontawesome from 6.4.2 to 6.5.1#2981

Merged
tbouffard merged 5 commits into
masterfrom
chore/demo_bump_fontawesome
Dec 4, 2023
Merged

chore(demo): bump fontawesome from 6.4.2 to 6.5.1#2981
tbouffard merged 5 commits into
masterfrom
chore/demo_bump_fontawesome

Conversation

@tbouffard

@tbouffard tbouffard commented Nov 29, 2023

Copy link
Copy Markdown
Member

Additional changes

  • use the minified version to speedup the download
  • get the asset from jsdelivr to use a strong CDN for a better reliability

Notes

v6.5.1 Changelog: https://fontawesome.com/docs/changelog/

@tbouffard tbouffard added the example This issue or pull request is related to the lib demo or examples label Nov 29, 2023
@github-actions

github-actions Bot commented Nov 29, 2023

Copy link
Copy Markdown

♻️ PR Preview 88825cd has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard

tbouffard commented Nov 29, 2023

Copy link
Copy Markdown
Member Author

⚠️ The fontawesome icon is no more displayed (upload icon)

Expected Current
image image

Console error

  • Firefox: A resource is blocked by OpaqueResponseBlocking, please check browser console for details. error 404
  • Chrome: Failed to load resource: the server responded with a status of 404 ()

[UPDATE 2023-12-01] The resource is now available

@tbouffard tbouffard changed the title chore(demo): bump fontawesome from 6.4.2 to 6.5.0 chore(demo): bump fontawesome from 6.4.2 to 6.5.1 Dec 1, 2023
@tbouffard tbouffard marked this pull request as ready for review December 1, 2023 15:36
@tbouffard tbouffard requested a review from csouchet December 1, 2023 15:36

@csouchet csouchet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo is ok:

@tbouffard tbouffard merged commit f2ca7f0 into master Dec 4, 2023
@tbouffard tbouffard deleted the chore/demo_bump_fontawesome branch December 4, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

example This issue or pull request is related to the lib demo or examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants