Skip to content

test(JsonBuilder): use the id of event for the id of eventDefinition#2910

Merged
csouchet merged 3 commits into
masterfrom
test/json_builder_use_id_of_event_for_id_of_event_definition
Oct 4, 2023
Merged

test(JsonBuilder): use the id of event for the id of eventDefinition#2910
csouchet merged 3 commits into
masterfrom
test/json_builder_use_id_of_event_for_id_of_event_definition

Conversation

@csouchet

@csouchet csouchet commented Oct 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

For the unit tests for the link events, we need to have id for eventDefinition understandable and to have tests more readable.

Example of a generated json for intermediateThrowEvent with a linkEventDefinition (with an id calculated from the id of the event)

      "intermediateThrowEvent": {
        "id": "source_id",

        "linkEventDefinition": {
          "id": "link_source_id",
          "target": "link_target_id"
        }
      }

@csouchet csouchet added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first labels Oct 3, 2023
@csouchet csouchet mentioned this pull request Oct 3, 2023
Merged
@csouchet csouchet force-pushed the test/json_builder_use_id_of_event_for_id_of_event_definition branch from 828f5ea to dc6c454 Compare October 4, 2023 07:54
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Oct 4, 2023
@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csouchet csouchet marked this pull request as ready for review October 4, 2023 07:58
@csouchet csouchet requested a review from tbouffard October 4, 2023 07:58
@csouchet csouchet merged commit e4953fe into master Oct 4, 2023
@csouchet csouchet deleted the test/json_builder_use_id_of_event_for_id_of_event_definition branch October 4, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees

No one assigned

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@csouchet @tbouffard