Skip to content

chore(eslint): add unicorn Switch rules#2881

Merged
csouchet merged 3 commits into
masterfrom
2742-add_unicorn_switch_rules
Sep 26, 2023
Merged

chore(eslint): add unicorn Switch rules#2881
csouchet merged 3 commits into
masterfrom
2742-add_unicorn_switch_rules

Conversation

@csouchet

@csouchet csouchet commented Sep 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@csouchet csouchet added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first refactoring Code refactoring labels Sep 20, 2023
@csouchet csouchet mentioned this pull request Sep 20, 2023
Merged
@github-actions

github-actions Bot commented Sep 20, 2023 •
edited
Loading

Copy link
Copy Markdown

🎊 PR Preview 18e4009 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2881.surge.sh

🕐 Build time: 0.021s

🤖 By surge-preview

@github-actions

github-actions Bot commented Sep 20, 2023 •
edited
Loading

Copy link
Copy Markdown

🎊 PR Preview 18e4009 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-2881.surge.sh

🕐 Build time: 0.016s

🤖 By surge-preview

@csouchet
add switch rules:
589df10 
- unicorn/no-useless-switch-case
- unicorn/prefer-switch
- unicorn/switch-case-braces
@csouchet
lint
ee7a75c
@csouchet csouchet force-pushed the 2742-add_unicorn_switch_rules branch from f7d739e to ee7a75c Compare September 25, 2023 13:58
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Sep 25, 2023
@csouchet csouchet marked this pull request as ready for review September 25, 2023 14:19
@csouchet csouchet requested a review from tbouffard September 25, 2023 14:19
tbouffard
tbouffard approved these changes Sep 25, 2023
View reviewed changes

@tbouffard tbouffard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/component/mxgraph/renderer/style-utils.ts
case BpmnStyleIdentifier.IS_INITIATING: // message flow icon
}
case BpmnStyleIdentifier.IS_INITIATING: {
// message flow icon

@tbouffard tbouffard Sep 25, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: may be clearer with the comment on the top of the case entry. This is what we generally do in the code.

@csouchet csouchet enabled auto-merge (squash) September 26, 2023 07:40
@csouchet csouchet merged commit 685b67c into master Sep 26, 2023
@csouchet csouchet deleted the 2742-add_unicorn_switch_rules branch September 26, 2023 07:41
@sonarqubecloud

sonarqubecloud Bot commented Sep 26, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees

No one assigned

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) refactoring Code refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@csouchet @tbouffard