Skip to content

chore(eslint): add unicorn/no-array-for-each rule#2868

Merged
csouchet merged 4 commits into
masterfrom
2742-add_unicorn/no-array-for-each_rule
Sep 21, 2023
Merged

chore(eslint): add unicorn/no-array-for-each rule#2868
csouchet merged 4 commits into
masterfrom
2742-add_unicorn/no-array-for-each_rule

Conversation

@csouchet

@csouchet csouchet commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

To avoid to have to many changes by enabling plugin:unicorn/recommended, I choose to enable some rule one-by-one.

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-array-for-each.md

Part of #2824

Covers #2742

@csouchet csouchet added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first refactoring Code refactoring labels Sep 19, 2023
@github-actions

github-actions Bot commented Sep 19, 2023

Copy link
Copy Markdown

🎊 PR Preview e2b775e has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2868.surge.sh

🕐 Build time: 0.018s

🤖 By surge-preview

@github-actions

github-actions Bot commented Sep 19, 2023

Copy link
Copy Markdown

♻️ PR Preview e2b775e has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet csouchet force-pushed the 2742-add_unicorn/no-array-for-each_rule branch from 28bd2fd to b4171f8 Compare September 21, 2023 07:36
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Sep 21, 2023
@csouchet csouchet marked this pull request as ready for review September 21, 2023 07:36
@csouchet csouchet requested a review from tbouffard September 21, 2023 07:37
…r: Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.
@csouchet csouchet force-pushed the 2742-add_unicorn/no-array-for-each_rule branch from 08c908e to 7722c2d Compare September 21, 2023 08:24

@tbouffard tbouffard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/component/parser/json/converter/CategoryConverter.ts Outdated
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@csouchet csouchet merged commit b7607cb into master Sep 21, 2023
@csouchet csouchet deleted the 2742-add_unicorn/no-array-for-each_rule branch September 21, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) refactoring Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants