chore(eslint): add eslint-plugin-import dependency#2842
Conversation
…import/no-unresolved The package.json of 'rollup-plugin-node-externals' is malformed, so the import doesn't work with 'eslint-plugin-import'.
csouchet
added
dependencies
|
♻️ PR Preview d066927 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
🎊 PR Preview d066927 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2842.surge.sh 🕐 Build time: 0.02s
🤖 By surge-preview |
tbouffard
left a comment
tbouffard
left a comment
There was a problem hiding this comment.
LGTM, this should simplify the review of the future PR. Good job, this plugin does the job well!
The review was tedious because I checked all the modified files, but it was worth it because I detected a few minor problems. 😄
| export * from './model/bpmn/internal'; | ||
|
|
||
| // not part of the public API but needed for the custom theme examples | ||
| export { IconPainter } from './component/mxgraph/shape/render/icon-painter'; |
Unable to resolve path to module 'bpmn-visualization' import/no-unresolved
tbouffard
left a comment
tbouffard
left a comment
There was a problem hiding this comment.
LGTM
Can you please answer to the open questions and integrate the proposed changes? As usual, we can quickly talk about them to converge and be able to merge 😸.
|
Kudos, SonarCloud Quality Gate passed! |
tbouffard
removed
the
dependencies
2 participants
This pull request addresses linting and import-related issues. Major changes include:
import/unresolvederrors.Covers #2742
Closes #2078