test: improvement management of asynchronous configuration#2817
Merged
Conversation
csouchet
added
the
chore
csouchet
force-pushed
the
fix_missing_async_handling_on_tests
branch
from
b1f5ade to
69812df
Compare
tbouffard
reviewed
Aug 25, 2023
tbouffard
left a comment
tbouffard
left a comment
Member
There was a problem hiding this comment.
I have a single remark about test/config/jest.image.ts, otherwise this looks OK
23 tasks
- disable 'require-await' rule
csouchet
force-pushed
the
fix_missing_async_handling_on_tests
branch
from
76548f7 to
2118d74
Compare
|
♻️ PR Preview 52f7de1 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 52f7de1 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
This reverts commit 1377c5c.
tbouffard
changed the title
tbouffard
approved these changes
Sep 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the POC PR #2812, I identified instances where asynchronous handling was missing in the tests.
The enabled rules are:
@typescript-eslint/require-await@typescript-eslint/no-misused-promises@typescript-eslint/no-floating-promises@typescript-eslint/require-awaitThe disabled rules are:
require-awaitCovers #2742