refactor(demo): fetch the BPMN diagrams#287
Merged
tbouffard merged 12 commits intoSep 11, 2024
Merged
Conversation
|
🎊 PR Preview 618d8c1 has been successfully built and deployed to https://process-analytics-bv-experimental-add-ons-demo-pr-287.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
Member
Author
Produced Chunksmain first implementation (duplicate diagram fetch in all demo entry points) 34b0b99 after introducing the ef7f787 final commit, after using the "import URL" support provided by vite (https://vitejs.dev/guide/assets#importing-asset-as-url) |
|
tbouffard
commented
Sep 11, 2024
tbouffard
left a comment
tbouffard
left a comment
Member
Author
There was a problem hiding this comment.
✔️ Tested locally with the development server
✔️ Tested with the surge preview environment
tbouffard
changed the title
tbouffard
deleted the
refactor/GH-72_bpmn_diagram_out_of_the_js_chunks
branch
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the diagram was stored in JavaScript chunks.
This increased the size of the chunks and did not reflect what an application generally does: it does not store diagrams, they are retrieved from services or APIs.
Fetching the diagram reduces the size of the JavaScript chunks and makes the demo closer to a real application.
Notes
Closes #72
Tasks
try to use import.meta.url when fetching the diagram, see https://vitejs.dev/guide/assets#new-url-url-import-meta-url: not needed, using the URL in import works