feat: introduce StyleByNamePlugin#281
Merged
Merged
Conversation
Provide the same API as `StyleRegistry` but pass names instead of ids to identify BPMN elements. NOTE: To map names to ids, the plugin uses `BpmnElementsSearcher`. The mapping is currently not cached, nor pre-fetched after the BPMN source has been loaded. So the implementation is not very effective. Caching and pre-fetch features will be implemented in the future.
|
🎊 PR Preview 58d74cf has been successfully built and deployed to https://process-analytics-bv-experimental-add-ons-demo-pr-281.surge.sh 🕐 Build time: 0.01s
🤖 By surge-preview |
[skip ci]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide the same API as
StyleRegistrybut pass names instead of ids to identify BPMN elements.NOTE: To map names to ids, the plugin uses
BpmnElementsSearcher.The mapping is currently not cached, nor pre-fetched after the BPMN source has been loaded.
So the implementation is not very effective. Caching and pre-fetch features will be implemented in
the future.
Notes
Closes #75
There is no demo of this plugin for now, it will be done as part of #78.