feat(demo): improve zoom control buttons#186
Merged
Merged
Conversation
Add title to buttons Do not display "Fit" but use an icon instead. The related title is now "Zoom reset" to use a more common wording. Zoom buttons are now managed by a dedicated component that hides the button logic and the style. This also paves the way for reuse of these buttons in other demos.
|
Kudos, SonarCloud Quality Gate passed!
|
|
♻️ PR Preview 0677277 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
csouchet
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add title to buttons
Do not display "Fit" but use an icon instead. The related title is now "Zoom reset" to use a more
common wording.
Zoom buttons are now managed by a dedicated component that hides the button logic and the style.
This also paves the way for reuse of these buttons in other demos.
Notes
Covers #170