Skip to content

feat(BpmnElementsSearcher): provide options to deduplicate elements#131

Merged
tbouffard merged 5 commits into
mainfrom
feat/elements_searcher_options_to_manage_duplicates_from_names
Oct 4, 2023
Merged

feat(BpmnElementsSearcher): provide options to deduplicate elements#131
tbouffard merged 5 commits into
mainfrom
feat/elements_searcher_options_to_manage_duplicates_from_names

Conversation

@tbouffard

@tbouffard tbouffard commented Sep 28, 2023

Copy link
Copy Markdown
Member

Introduce a new method that returns the whole BpmnSemantic object. It includes a parameter allowing the caller to choose how to deduplicate elements with the same name.

Covers #114

Notes

The type name of the new options has been chosen to be general enough to be reused in plugins dealing with "name" parameters. See

@tbouffard tbouffard added the enhancement New feature or request label Sep 28, 2023
@github-actions

github-actions Bot commented Sep 28, 2023

Copy link
Copy Markdown

♻️ PR Preview 889f26b has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard tbouffard force-pushed the feat/elements_searcher_options_to_manage_duplicates_from_names branch from ef791a6 to 6149e8a Compare October 2, 2023 17:30
Introduce a new method that returns the whole BpmnSemantic object. It has a parameter letting the
caller choose how to deduplicate elements with the same name.
@tbouffard tbouffard force-pushed the feat/elements_searcher_options_to_manage_duplicates_from_names branch from 6149e8a to c48d64d Compare October 3, 2023 15:54
@tbouffard tbouffard changed the title feat: BpmnElementsSearcher add options to choose how to deduplicate feat(BpmnElementsSearcher): provide options to deduplicate elements Oct 3, 2023
@tbouffard tbouffard marked this pull request as ready for review October 3, 2023 15:59
@tbouffard tbouffard requested a review from csouchet October 3, 2023 15:59
Comment thread packages/addons/src/bpmn-elements.ts Outdated
@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tbouffard tbouffard merged commit 59e8593 into main Oct 4, 2023
@tbouffard tbouffard deleted the feat/elements_searcher_options_to_manage_duplicates_from_names branch October 4, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants