feat: improve the robustness of PathResolver#119
Merged
Conversation
|
♻️ PR Preview 36595e0 has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
|
Kudos, SonarCloud Quality Gate passed!
|
csouchet
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Add several unit tests and simplify the implementation.
closes #18
Notes
Current limitation
The current implementation doesn't filter out erroneous edge identifiers that are resolved from incorrectly defined incoming and outgoing identifiers.
bpmn-visualizationdoesn't filter them out itself when it should, so I decided not to do it here but to create an issue in thebpmn-visualizationrepository instead: process-analytics/bpmn-visualization-js#2852Note that the old implementation didn't filter out these erroneous edge identifiers either, so there's no reason to keep it instead of switching to the new implementation.
All code is now fully covered by tests 🎉