Skip to content

feat: improve the robustness of PathResolver#119

Merged
tbouffard merged 20 commits into
mainfrom
feat/18-robustness_PathResolver
Sep 12, 2023
Merged

feat: improve the robustness of PathResolver#119
tbouffard merged 20 commits into
mainfrom
feat/18-robustness_PathResolver

Conversation

@tbouffard

@tbouffard tbouffard commented Sep 11, 2023

Copy link
Copy Markdown
Member

Add several unit tests and simplify the implementation.

closes #18

### Tasks
- [x] Check if we need the code that currently check that edges really exist in the model
- [x] Refactor the implementation if possible
- [x] Add link to the bpmn-visualization issue in tests to explain why extra erroneous edge ids are returned (the test will break once `bv-experimental-add-ons` uses the new release)

Notes

Current limitation

The current implementation doesn't filter out erroneous edge identifiers that are resolved from incorrectly defined incoming and outgoing identifiers. bpmn-visualization doesn't filter them out itself when it should, so I decided not to do it here but to create an issue in the bpmn-visualization repository instead: process-analytics/bpmn-visualization-js#2852

Note that the old implementation didn't filter out these erroneous edge identifiers either, so there's no reason to keep it instead of switching to the new implementation.

All code is now fully covered by tests 🎉

=============================== Coverage summary ===============================
Statements   : 100% ( 63/63 )
Branches     : 100% ( 26/26 )
Functions    : 100% ( 19/19 )
Lines        : 100% ( 62/62 )
================================================================================

@tbouffard tbouffard added the enhancement New feature or request label Sep 11, 2023
@github-actions

github-actions Bot commented Sep 11, 2023

Copy link
Copy Markdown

♻️ PR Preview 36595e0 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tbouffard tbouffard marked this pull request as ready for review September 12, 2023 09:45
@tbouffard tbouffard requested a review from csouchet September 12, 2023 09:45
@tbouffard tbouffard merged commit 7eebd9a into main Sep 12, 2023
@tbouffard tbouffard deleted the feat/18-robustness_PathResolver branch September 12, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Improve robustness of PathResolver

2 participants