Repository navigation
Commit a305f36
authored
fix: isolate hook state per async module.register() registration
## Problem
`tsImport()` stops settling after ~5 calls on Node versions that use the
async `module.register()` path (below v24.11.1 / v25.1.0): resolution
work multiplies ~10x per call, so the 6th call appears to hang forever.
Regression in 4.22.0.
The async path registers a cache-busted copy of the hook entry
(`./esm/index.mjs?<timestamp>`) per registration so that each copy gets
its own state. Since 4.22.0, `esm/api/register.ts` imports the hook
factories for the sync `module.registerHooks()` path, which moved the
hook modules — including the mutable `data` singleton — into a bundler
chunk shared by both entries. Chunks evaluate once per thread, so every
registration's `initialize()` mutated the same object: all chained
registrations claimed the latest namespace, and each chain entry
re-applied TypeScript extension guessing to the failed candidates of the
hook below it.
Fixes #806
## Changes
- Hook state is now created in the hook entry module itself
(`src/esm/index.ts`) — the unit the async path cache-busts — so each
registration gets its own state regardless of how the bundler chunks
shared modules.
- `initialize` / `globalPreload` / `load` / `resolve` are constructed
per entry evaluation from factories; the module-level `data` singleton
is removed (`createDefaultData()` + `createInitialize()` /
`createGlobalPreload()`).
- Regression test: repeated `tsImport()` of a failing import must reject
every call. Runs across the CI Node matrix, so Node 18/20/22 exercise
the async path.1 parent ca501a9 commit a305f36
6 files changed
Lines changed: 83 additions & 16 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
14 | 25 | | |
15 | 26 | | |
16 | | - | |
17 | | - | |
18 | | - | |
| 27 | + | |
19 | 28 | | |
20 | 29 | | |
21 | 30 | | |
| |||
38 | 47 | | |
39 | 48 | | |
40 | 49 | | |
41 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
42 | 53 | | |
43 | 54 | | |
44 | 55 | | |
| |||
61 | 72 | | |
62 | 73 | | |
63 | 74 | | |
64 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
65 | 78 | | |
66 | 79 | | |
67 | 80 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
598 | 598 | | |
599 | 599 | | |
600 | 600 | | |
601 | | - | |
602 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| |||
850 | 850 | | |
851 | 851 | | |
852 | 852 | | |
853 | | - | |
854 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
7 | 10 | | |
8 | 11 | | |
9 | 12 | | |
| |||
22 | 25 | | |
23 | 26 | | |
24 | 27 | | |
25 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
922 | 922 | | |
923 | 923 | | |
924 | 924 | | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
925 | 972 | | |
926 | 973 | | |
927 | 974 | | |
| |||
0 commit comments