Skip to content

Implement escaping and unescaping of special characters in string literals across connectors#738

Merged
tomhoule merged 6 commits intomasterfrom
string-literals-escaping
May 14, 2020
Merged

Implement escaping and unescaping of special characters in string literals across connectors#738
tomhoule merged 6 commits intomasterfrom
string-literals-escaping

Conversation

@tomhoule
Copy link
Copy Markdown
Contributor

@tomhoule tomhoule commented May 7, 2020

Restructuring of #733 into a cleaner commit history.

Addresses #691
Closes prisma/prisma#1888

Blocked on prisma/quaint#130

@tomhoule tomhoule added tech/engines/migration engine Issue in the Migration Engine tech/engines/introspection engine Issue in the Introspection Engine tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema labels May 7, 2020
@tomhoule tomhoule added this to the Beta 5 milestone May 7, 2020
@tomhoule
Copy link
Copy Markdown
Contributor Author

@tomhoule tomhoule force-pushed the string-literals-escaping branch from 3ef2074 to 8ab73bb Compare May 12, 2020 09:20
@janpio janpio modified the milestones: Beta 5, Beta 6 May 12, 2020
@tomhoule
Copy link
Copy Markdown
Contributor Author

Things that were decided during review with @do4gr

  • Do the godzilla roundtrip test in the schema parser too
  • Write tests for the case of the issue linked in the description

First point is done, started on the second one, but it will need non-test changes too.

@tomhoule tomhoule force-pushed the string-literals-escaping branch from 6810462 to d7f034f Compare May 14, 2020 13:01
@tomhoule tomhoule merged commit 69a699b into master May 14, 2020
@tomhoule tomhoule deleted the string-literals-escaping branch May 14, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema tech/engines/introspection engine Issue in the Introspection Engine tech/engines/migration engine Issue in the Migration Engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introspect default value with backslashes causes problem when generating client

2 participants