Do not panic in certain index validations#1603
Merged
Conversation
If we have two models:
```prisma
model A {
id Int @id @derfault(autoincrement())
b Int
@@index([b], name: "foo")
}
model B {
id Int @id @derfault(autoincrement())
a Int
@@unique([a], name: "foo")
}
```
Both models will have an index, but the data we only looked with the
attribute name `index`, not with `unique`.
tomhoule
approved these changes
Feb 3, 2021
Contributor
tomhoule
left a comment
tomhoule
left a comment
There was a problem hiding this comment.
lgtm! I know you probably weighed the tradeoff already, but sure this doesn't need a separate test and adjusting the existing one won't introduce a gap?
| let ast_index = ast_model | ||
| .attributes | ||
| .iter() | ||
| .find(|attribute| attribute.name.name == "index") |
| .attributes | ||
| .iter() | ||
| .find(|attribute| attribute.name.name == "index") | ||
| .find(|attribute| attribute.is_index()) |
Contributor
Author
|
I'm still not sure is this correct. What if the model have two indexes? It chooses the first for error message?? |
Contributor
Author
Added a test. |
Contributor
|
looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we have two models:
Both models will have an index with a same name, but the data we only looked with the attribute name
index, not withunique. On PostgreSQL this is a validation error, but instead we panic.Closes: prisma/prisma#5171