chore(cli): warn if unsupported/missing typescript version#6060
Merged
timsuchanek merged 3 commits intomasterfrom Mar 15, 2021
Merged
chore(cli): warn if unsupported/missing typescript version#6060timsuchanek merged 3 commits intomasterfrom
timsuchanek merged 3 commits intomasterfrom
Conversation
Contributor
|
We should not require typescript dependency or warn that it's not there in my opinion. If you're a Node.js user and not using TypeScript you don't want warnings about it if you're happy with your .js code. |
Contributor
|
I agree. Warning when typescript is installed should be enough. |
Contributor
|
Also I'm curious about how much time it takes to do One alternative would be to look for the package.json |
Jolg42
reviewed
Mar 15, 2021
Jolg42
reviewed
Mar 15, 2021
Co-authored-by: Joël Galeran <[email protected]>
This was referenced Mar 16, 2021
This was referenced Mar 18, 2021
Andrew-Colman
pushed a commit
to Andrew-Colman/prisma
that referenced
this pull request
Aug 7, 2021
Co-authored-by: Joël Galeran <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5728
When
tscis not presentWhen
tscis outdatedI also added
typescript:>=4.1to the cli's peerDeps as this will warn on install.