Merged
Conversation
Closed
* master: ci: update uri for github actions (#5469) chore: add mssql shortcut for tests [skip ci] Revert "ci: update uri for github actions" ci: update uri for github actions ci: pin github actions to ubuntu-18.04 fix(deps): update engines to v2.17.0-5.b461f67b862d1920b19389df49c7dbbd2a30efff (#5465) fix(deps): update engines to v2.17.0-4.62e1b79e1c93665abe9d3a3694eba727695dcf82 (#5463) chore: set renovate ignoreUnstable to false [skip ci] # Conflicts: # src/packages/cli/package.json # src/packages/client/package.json # src/packages/engine-core/package.json # src/packages/fetch-engine/package.json # src/packages/migrate/package.json # src/packages/sdk/package.json
1 task
Contributor
|
Looks good! Please also add compatibility code as we have for other feature flags here: So that it's not crashing for people who still use the feature flag, but just a warning. |
1 task
williamluke4
approved these changes
Feb 5, 2021
Contributor
Author
|
Good point @timsuchanek added in 3bddead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.