Skip to content

fix(client): improve error links#4753

Merged
timsuchanek merged 15 commits intomasterfrom
even-better-error-links
Dec 21, 2020
Merged

fix(client): improve error links#4753
timsuchanek merged 15 commits intomasterfrom
even-better-error-links

Conversation

@timsuchanek
Copy link
Copy Markdown
Contributor

const engineVersion = await this.version(true)
debug(`Client Version: ${this.clientVersion}`)
debug(`Engine Version: ${engineVersion}`)
const activeProvider = await this.getActiveProvider()
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially related to test failure


async getActiveProvider(): Promise<ConnectorType> {
const config = await this.getConfig()
this.lastActiveProvider = config.datasources[0].activeProvider
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially related to test failure

this.currentRequestPromise = this.undici.request(JSON.stringify(body))
const stringifiedQuery = JSON.stringify(body)

this.currentRequestPromise = this.undici!.request(stringifiedQuery)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially related to test failure

}

private getErrorMessageWithLink(title: string) {
return getErrorMessageWithLink({
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially related to test failure


// take the source's encoding if we don't have one
this.on('pipe', function (src) {
this.on('pipe', function (this, src) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially related to test failure

@timsuchanek timsuchanek added this to the 2.14.0 milestone Dec 21, 2020
@timsuchanek timsuchanek merged commit 5b40e3b into master Dec 21, 2020
@timsuchanek timsuchanek deleted the even-better-error-links branch December 21, 2020 13:37
Jolg42 added a commit that referenced this pull request Dec 28, 2020
* master:
  fix(deps): update engines to v2.14.0-26.59cf08bf47e90cb37532900059f3328b4328237c (#4774)
  chore(deps): update definitelytyped
  fix(client): raw transactions (#4759)
  fix(deps): update engines to v2.14.0-22.85cf7930a5fc63cd99fa483153fd33cb35d49cfa
  chore(deps): update studio to v0.332.0
  fix(client): improve error links (#4753)
  fix(deps): update engines to v2.14.0-21.aed47bccd0e3bc61e2a26b14315e2dd839d35a12
  chore: bump engines (#4749)
  fix: fail early for known errors (#4734)
  chore: cleanup (#4707)
  fix(debug): allow multiple instances (#4665)
  chore: wip debug vercel (#4705)
  fix(deps): update engines to v2.14.0-17.af950b3705ef175e85492660c621085eb7f99557
  chore(deps): update dependency rollup-plugin-dts to v2 (#4323)
  feat(client): add more jsdoc to Prisma Client (#4388)
  fix(deps): update engines to v2.14.0-16.c033861e8ed093701af214a25e2bb3e03edacf7c

# Conflicts:
#	package.json
#	pnpm-lock.yaml
#	src/packages/client/package.json
#	src/packages/client/src/runtime/getPrismaClient.ts
#	src/packages/debug/package.json
#	src/packages/engine-core/package.json
#	src/packages/generator-helper/package.json
#	src/packages/get-platform/package.json
#	src/pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated Github issue creation links do often not include helpful information

1 participant