feat(client): validate constructor#4176
Merged
timsuchanek merged 6 commits intomasterfrom Nov 9, 2020
Merged
Conversation
Contributor
|
Looks like Studio tests are failing https://github.com/prisma/prisma/pull/4176/checks?check_run_id=1364713203#step:6:592 |
Contributor
Author
|
@Jolg42 yep. @madebysid and I are already debugging |
Jolg42
reviewed
Nov 9, 2020
| expect(() => | ||
| validatePrismaClientOptions( | ||
| { | ||
| errorrFormat: 'minimal', |
Contributor
There was a problem hiding this comment.
Trying to mess with some brains? 😄
Jolg42
reviewed
Nov 9, 2020
Jolg42
approved these changes
Nov 9, 2020
Contributor
Jolg42
left a comment
Jolg42
left a comment
There was a problem hiding this comment.
Nice! Maybe the logs could link to https://www.prisma.io/docs/concepts/components/prisma-client/constructor ?
Contributor
|
Note From what I understand it fails at the first error found ✅ |
Contributor
|
✨ Nice! |
Jolg42
added a commit
that referenced
this pull request
Nov 10, 2020
* master: fix: fork Node generators (#4214) chore(deps): update studio to v0.311.0 fix: bump engines (#4207) ci: Test Buildkite config 10 & 14 ci: revert buildkite test pipeline [skip ci] ci: test Buildkite config ci: test Buildkite config chore(deps): update dependency @types/node to v12.19.4 chore(deps): update devdependencies (non-major) feat(client): validate constructor (#4176)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes prisma/prisma-client-js#889