fix(client): stack trace with source-map-support. Closes #3945#4137
Merged
timsuchanek merged 4 commits intomasterfrom Nov 3, 2020
Merged
fix(client): stack trace with source-map-support. Closes #3945#4137timsuchanek merged 4 commits intomasterfrom
timsuchanek merged 4 commits intomasterfrom
Conversation
Jolg42
reviewed
Nov 3, 2020
Comment on lines
+51
to
+53
| # https://stackoverflow.com/questions/55559386/how-to-fix-mbind-operation-not-permitted-in-mysql-error-log | ||
| cap_add: | ||
| - SYS_NICE # CAP_SYS_NICE |
Contributor
There was a problem hiding this comment.
Looks unrelated, first time I see that.
Did it happen on your Linux machine?
Contributor
Author
There was a problem hiding this comment.
Yes, happened on my Linux machine
Jolg42
reviewed
Nov 3, 2020
Jolg42
reviewed
Nov 3, 2020
Jolg42
approved these changes
Nov 3, 2020
Contributor
Jolg42
left a comment
Jolg42
left a comment
There was a problem hiding this comment.
See comments, looks good!
Co-authored-by: Joël Galeran <[email protected]>
Contributor
|
New snapshots are 😍 |
Jolg42
added a commit
that referenced
this pull request
Nov 4, 2020
* master: (25 commits) chore: cleanup tests chore: update snapshots fix: only generate .env path if present fix: improve warning fix(client): stack trace with source-map-support. Closes #3945 (#4137) feat(client, sdk, cli): env loading rewrite (#4142) ci: increase health check retries for db GH Actions fix(deps): update dependency undici to v2.1.1 (#4135) chore(deps): update devdependencies (non-major) fix(deps): update engines to v2.11.1-4-1d5919363a85847350c3f517da9babd9bcaca792 (#4131) ci: try fix for flaky client GH actions chore(deps): update studio to v0.307.0 (#4128) fix(client): remove package.json in custom output paths (#4130) feat: stabilize transaction & connectOrCreate (#4129) fix: print getConfig warnings (#4124) fix(cli): Ignore all errors that occur when opening Studio in a browser (#4119) chore: update renovate for Studio [skip ci] Bump Studio [skip ci] chore(cli): preinstall throw on node < 10 (#4118) chore: cleanup jest config (#4120) ... # Conflicts: # src/packages/migrate/src/bin.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3945
The parsing logic of the stack trace is now moved out to a separate function called
parseStack.Also we're printing the "simple" stack without the concrete stack trace, if the line, that we found doesn't contain Prisma.