Skip to content

chore(cli): preinstall throw on node < 10#4118

Merged
Jolg42 merged 3 commits intomasterfrom
chore/preinstall-throw-node<10
Nov 2, 2020
Merged

chore(cli): preinstall throw on node < 10#4118
Jolg42 merged 3 commits intomasterfrom
chore/preinstall-throw-node<10

Conversation

@williamluke4
Copy link
Copy Markdown

No description provided.

@Jolg42
Copy link
Copy Markdown
Contributor

Jolg42 commented Nov 2, 2020

Did you try to run the code with old Node version, maybe take a screenshot?

@williamluke4
Copy link
Copy Markdown
Author

image

@Jolg42 Jolg42 linked an issue Nov 2, 2020 that may be closed by this pull request
Comment thread src/packages/cli/scripts/preinstall.js Outdated
@Jolg42 Jolg42 added this to the Release 2.11.0 milestone Nov 2, 2020
Copy link
Copy Markdown
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jolg42 Jolg42 merged commit 87d13fd into master Nov 2, 2020
@Jolg42 Jolg42 deleted the chore/preinstall-throw-node<10 branch November 2, 2020 13:29
Jolg42 added a commit that referenced this pull request Nov 4, 2020
* master: (25 commits)
  chore: cleanup tests
  chore: update snapshots
  fix: only generate .env path if present
  fix: improve warning
  fix(client): stack trace with source-map-support. Closes #3945 (#4137)
  feat(client, sdk, cli): env loading rewrite (#4142)
  ci: increase health check retries for db GH Actions
  fix(deps): update dependency undici to v2.1.1 (#4135)
  chore(deps): update devdependencies (non-major)
  fix(deps): update engines to v2.11.1-4-1d5919363a85847350c3f517da9babd9bcaca792 (#4131)
  ci: try fix for flaky client GH actions
  chore(deps): update studio to v0.307.0 (#4128)
  fix(client): remove package.json in custom output paths (#4130)
  feat: stabilize transaction & connectOrCreate (#4129)
  fix: print getConfig warnings (#4124)
  fix(cli): Ignore all errors that occur when opening Studio in a browser (#4119)
  chore: update renovate for Studio [skip ci]
  Bump Studio [skip ci]
  chore(cli): preinstall throw on node < 10 (#4118)
  chore: cleanup jest config (#4120)
  ...

# Conflicts:
#	src/packages/migrate/src/bin.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect and enforce Node Version in preinstall hook so pnpm fails clearly

2 participants