Skip to content

chore: Integration/prisma/engines#3942

Merged
timsuchanek merged 47 commits intomasterfrom
integration/prisma/engines
Oct 21, 2020
Merged

chore: Integration/prisma/engines#3942
timsuchanek merged 47 commits intomasterfrom
integration/prisma/engines

Conversation

@timsuchanek
Copy link
Copy Markdown
Contributor

@timsuchanek timsuchanek commented Oct 15, 2020 •
edited
Loading

Closes #3928

@timsuchanek timsuchanek changed the title Integration/prisma/engines chore: Integration/prisma/engines Oct 15, 2020
@timsuchanek timsuchanek marked this pull request as ready for review October 21, 2020 14:14
@Jolg42 Jolg42 self-requested a review October 21, 2020 14:17
@Jolg42 Jolg42 added this to the Release 2.10.0 milestone Oct 21, 2020
Jolg42
Jolg42 reviewed Oct 21, 2020
View reviewed changes
Comment thread src/packages/cli/scripts/install.js Outdated
Jolg42
Jolg42 reviewed Oct 21, 2020
View reviewed changes
Comment thread src/packages/cli/scripts/download.js
@@ -1,122 +0,0 @@
const { download } = require('@prisma/fetch-engine')
Copy link
Copy Markdown
Contributor

@Jolg42 Jolg42 Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this went to https://github.com/prisma/engines-wrapper/blob/master/packages/engines/src/download.ts

Copy link
Copy Markdown
Contributor Author

@timsuchanek timsuchanek Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct :)

Jolg42
Jolg42 reviewed Oct 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests for https://github.com/prisma/engines-wrapper/blob/master/packages/engines/src/__tests__/all-exist.test.ts state is "TODO" 😄

Jolg42
Jolg42 reviewed Oct 21, 2020
View reviewed changes
Comment thread src/packages/sdk/src/engineCommands.ts
path.join(__dirname, '../query-engine-darwin')
path.join(__dirname, '../introspection-engine-darwin')
path.join(__dirname, '../prisma-fmt-darwin')
// commented out, as these paths are different now with @prisma/engines
Copy link
Copy Markdown
Contributor

@Jolg42 Jolg42 Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not removed?

Copy link
Copy Markdown
Contributor Author

@timsuchanek timsuchanek Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because they might be needed, so I want to keep the hints for now.
We'll see in the e2e tests if they're needed.

Jolg42
Jolg42 suggested changes Oct 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

Could you update this https://github.com/prisma/prisma/blob/master/src/package.json#L32 and remove download-all?

@timsuchanek
Copy link
Copy Markdown
Contributor Author

timsuchanek commented Oct 21, 2020

Looks like tests for prisma/engines-wrapper@master/packages/engines/src/tests/all-exist.test.ts state is "TODO" 😄

That is correct :)
As our pipeline is only triggered, after the engines release is fully done, it's not urgent.

@timsuchanek timsuchanek merged commit 71987dd into master Oct 21, 2020
@timsuchanek timsuchanek deleted the integration/prisma/engines branch October 21, 2020 14:43
Jolg42 added a commit that referenced this pull request Oct 21, 2020
@Jolg42
Merge branch 'master' into pr/migrate
711ac3d 
* master:
  feat(sdk): load .env from project root (#3971)
  chore: Integration/prisma/engines (#3942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Jolg42 Jolg42 Jolg42 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 2.10.0

Development

Successfully merging this pull request may close these issues.

Introduce @prisma/engines package

2 participants

@timsuchanek @Jolg42