Skip to content

fix: fix citext test#28906

Merged
jacek-prisma merged 1 commit intomainfrom
fix/fix-citext-test
Dec 12, 2025
Merged

fix: fix citext test#28906
jacek-prisma merged 1 commit intomainfrom
fix/fix-citext-test

Conversation

@jacek-prisma
Copy link
Copy Markdown
Contributor

@jacek-prisma jacek-prisma commented Dec 11, 2025

TML-1647

The issue is that the CITEXT is not in the search path during the execution of the query. The query just returns an empty list of rows and the comparison fails silently.

The schema search path problem is linked to the known issue of adapter-pg not behaving like the Rust driver with regard to the schema parameter.

Summary by CodeRabbit

  • Tests
    • Re-enabled case-insensitive field matching test for PostgreSQL with improved configuration, enhancing test coverage for the feature.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 11, 2025

Walkthrough

Re-enabled a previously disabled test case for PostgreSQL case-insensitive field matching. The test now uses explicit schema qualification for the citext extension and type references, verifying case-insensitive email queries work correctly.

Changes

Cohort / File(s) Change Summary
PostgreSQL test scenario re-enablement
packages/integration-tests/src/__tests__/integration/postgresql/__scenarios.ts
Re-enabled "findMany where - case insensitive field" test case with schema-qualified citext type (public.citext) for the email column. Test validates case-insensitive matching functionality when querying PostgreSQL with citext extension.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: fix citext test' directly relates to the main change: re-enabling and fixing a citext test case by qualifying it with schema references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/fix-citext-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
packages/client/runtime/index-browser.js 2.23 KB (0%)
packages/client/runtime/index-browser.d.ts 3.28 KB (0%)
packages/cli/build/index.js 2.52 MB (0%)
packages/client/prisma-client-0.0.0.tgz 10.24 MB (0%)
packages/cli/prisma-0.0.0.tgz 6.71 MB (0%)
packages/bundle-size/da-workers-libsql/output.tgz 805.36 KB (0%)
packages/bundle-size/da-workers-neon/output.tgz 859.41 KB (0%)
packages/bundle-size/da-workers-pg/output.tgz 852.35 KB (0%)
packages/bundle-size/da-workers-planetscale/output.tgz 804.92 KB (0%)
packages/bundle-size/da-workers-d1/output.tgz 788.27 KB (0%)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 12, 2025
@aqrln aqrln added this to the 7.2.0 milestone Dec 12, 2025
@jacek-prisma jacek-prisma merged commit 605a492 into main Dec 12, 2025
33 of 34 checks passed
@jacek-prisma jacek-prisma deleted the fix/fix-citext-test branch December 12, 2025 12:39
jkomyno pushed a commit that referenced this pull request Dec 16, 2025
[TML-1647](https://linear.app/prisma-company/issue/TML-1647/fix-broken-citext-integration-test)

The issue is that the CITEXT is not in the search path during the
execution of the query. The query just returns an empty list of rows and
the comparison fails silently.

The schema search path problem is linked to the known issue of
adapter-pg not behaving like the Rust driver with regard to the schema
parameter.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Tests**
* Re-enabled case-insensitive field matching test for PostgreSQL with
improved configuration, enhancing test coverage for the feature.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants