feat: Make Prisma Studio work with `directUrl` #20417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

millsp merged 18 commits into main from integration/studio-directUrl

Jul 29, 2023

Contributor

janpio commented Jul 27, 2023 •

edited by millsp

Loading

Closes #17358

Depends on https://github.com/prisma/studio-code/pull/483
Related docs change: prisma/docs#4953

Internal discussion: prisma-company.slack.com/archives/CC8F34ALF/p1685742636214419?thread_ts=1685736658.218249&cid=CC8F34ALF

janpio and others added 15 commits

June 2, 2023 23:21


          temp(checkUnsupportedDataProxy): Test what happens when removing stud…

…io limitation for directUrl


          Fix unrelated error msg

69195ca


          nwe getDirectUrl method in internals

55b3aef


          and use it

d30b98f


          comment out obsolete studio tests

6b8ffe0


          fix lint

6420b4c


          remove outdated tests

664c113


          remove more

4bfb8e5


          Merge branch 'main' into integration/studio-directUrl

bd39c22


          Merge branch 'main' into integration/studio-directUrl

c661fbd


          update studio to 0.488.0

4b17fe9


          Merge branch 'main' into integration/studio-directUrl

f0577be


          Add debug logging

c5cc1fa


          Update packages/cli/src/Studio.ts

c9abd3c


          Remove debug logging again

5e0a47d

janpio commented

View reviewed changes

packages/internals/src/cli/checkUnsupportedDataProxy.ts Outdated Show resolved Hide resolved

janpio commented

View reviewed changes

packages/cli/src/Studio.ts Outdated Show resolved Hide resolved

janpio commented

View reviewed changes

packages/cli/src/__tests__/commands/Studio.test.ts Show resolved Hide resolved

janpio commented

View reviewed changes

packages/cli/src/__tests__/commands/Studio.test.ts Show resolved Hide resolved

This was referenced Jul 27, 2023

chore: Remove directUrl limitation for Studio prisma/docs#4953

Merged

feat: Make Prisma Studio work with directUrl #19583

Closed

janpio commented

View reviewed changes

packages/cli/src/Studio.ts Outdated Show resolved Hide resolved


          Update packages/cli/src/Studio.ts

b91e64b

millsp self-assigned this

janpio added this to the 5.1.0 milestone

janpio marked this pull request as ready for review

July 28, 2023 10:14

janpio requested a review from a team as a code owner

July 28, 2023 10:14

janpio requested review from Jolg42 and aqrln and removed request for a team

July 28, 2023 10:14

Contributor Author

janpio commented Jul 28, 2023

This can manually be tested via [email protected].

millsp self-requested a review

July 28, 2023 13:44

millsp reviewed

View reviewed changes

packages/client/src/runtime/utils/validatePrismaClientOptions.ts Outdated Show resolved Hide resolved


          update tests

6efcadf

millsp approved these changes

View reviewed changes


          add missing dockers

janpio commented

View reviewed changes

Contributor Author

janpio left a comment

Nice changes to the tests, thank you!

millsp merged commit 76d0bbc into main

millsp deleted the integration/studio-directUrl branch

July 29, 2023 02:52

overbit pushed a commit to overbit/prisma that referenced this pull request


          feat: Make Prisma Studio work with directUrl (prisma#20417)

30cf104

Co-authored-by: Joël Galeran <[email protected]>
Co-authored-by: Pierre-Antoine Mills <[email protected]>

Jolg42 added a commit that referenced this pull request


          test(cli): remove unused databases from GitHub Actions

4d5906f

Follows #20417

Jolg42 mentioned this pull request

test(cli): remove unused databases from GitHub Actions #20503

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Jolg42 Awaiting requested review from Jolg42 Jolg42 was automatically assigned from prisma/orm-ts-maintain

aqrln Awaiting requested review from aqrln aqrln was automatically assigned from prisma/orm-ts-maintain

1 more reviewer

millsp millsp approved these changes

Labels

None yet