fix: do not followSymlinks when watching for file changes#651
Merged
carmenberndt merged 2 commits intomasterfrom Dec 9, 2020
Merged
fix: do not followSymlinks when watching for file changes#651carmenberndt merged 2 commits intomasterfrom
carmenberndt merged 2 commits intomasterfrom
Conversation
divyenduz
approved these changes
Dec 9, 2020
|
Thanks for the fix @carmenberndt! Out of curiosity, shouldn't |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #604
In yarn workspaces packages are symlinked, so chokidar ends up watching all file changes. Setting
followSymlinks: false, only the symlinks themselves will be watched for changes instead of following the link references and bubbling events through the link's path.