Skip to content

feat(custom icon)#137

Merged
carmenberndt merged 3 commits intomasterfrom
customIcon
May 25, 2020
Merged

feat(custom icon)#137
carmenberndt merged 3 commits intomasterfrom
customIcon

Conversation

@carmenberndt
Copy link
Copy Markdown
Contributor

@carmenberndt carmenberndt commented May 12, 2020

closes #5

Adds the prisma logo to .prisma files.

@carmenberndt
Copy link
Copy Markdown
Contributor Author

carmenberndt commented May 12, 2020

customIcon

@janpio
Copy link
Copy Markdown
Contributor

janpio commented May 12, 2020

Hm, not super convincing to be honest. We should definitely involve a designer to redraw the icon in the small size for it to be better defined.

Can you show examples of other languages and tools? Is there a common visual language for these icons?

@carmenberndt
Copy link
Copy Markdown
Contributor Author

carmenberndt commented May 12, 2020

Both png and svg files are supported, as well as a specified font. (https://code.visualstudio.com/api/extension-guides/file-icon-theme#icon-definitions)

Other languages:
lintIcon
rustIcon

graphqlIcon

@carmenberndt
Copy link
Copy Markdown
Contributor Author

carmenberndt commented May 18, 2020

Update: Used same icon for Prisma files as the Material Icon Theme
https://raw.githubusercontent.com/PKief/vscode-material-icon-theme/master/icons/prisma.svg

@carmenberndt
Copy link
Copy Markdown
Contributor Author

carmenberndt commented May 18, 2020

newIcon

@carmenberndt carmenberndt removed the request for review from matthewmueller May 18, 2020 16:12
janpio
janpio approved these changes May 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but we should get some design and devrel review here - it is quite a fundamental change.

2color
2color approved these changes May 18, 2020
View reviewed changes
Copy link
Copy Markdown

@2color 2color left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It looks slightly higher than the text, but I'm not sure if that's due to the shape or alignment.
Would be good to get design's input.

@hrescak
Copy link
Copy Markdown

hrescak commented May 18, 2020

I do agree it sits a little high and small. @carmenberndt can we try this adjusted version?

<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill-rule="evenodd" clip-rule="evenodd" d="M19.2081 18.797L9.44763 21.6094C9.14948 21.6954 8.86366 21.4441 8.92637 21.1511L12.4131 4.88161C12.4784 4.57738 12.91 4.52907 13.0462 4.81081L19.5022 18.1676C19.624 18.4196 19.4851 18.7166 19.208 18.7964L19.2081 18.797ZM20.8817 18.1337L13.4065 2.66782V2.66749C13.219 2.28086 12.8278 2.02576 12.3844 2.0021C11.9295 1.97629 11.5219 2.19004 11.292 2.55384L3.1848 15.3473C2.93365 15.7461 2.93857 16.2377 3.19906 16.6316L7.16204 22.6126C7.39825 22.9696 7.80747 23.1762 8.2328 23.1762C8.35337 23.1762 8.4746 23.1597 8.59382 23.1253L20.0977 19.8106C20.4501 19.709 20.7382 19.4662 20.889 19.1442C21.0393 18.8221 21.0369 18.4535 20.8822 18.1336L20.8817 18.1337Z" fill="#00BFA5"/>
</svg>

@carmenberndt
Copy link
Copy Markdown
Contributor Author

carmenberndt commented May 19, 2020

Sure, this is the adjusted version:
adjustedVersion

@carmenberndt carmenberndt added this to the Beta 6 milestone May 22, 2020
@hrescak
Copy link
Copy Markdown

hrescak commented May 22, 2020

lgtm!

@janpio janpio modified the milestone: Beta 6 May 22, 2020
@carmenberndt carmenberndt merged commit 38d1e2d into master May 25, 2020
@carmenberndt carmenberndt deleted the customIcon branch May 25, 2020 07:06
carmenberndt added a commit that referenced this pull request May 25, 2020
@carmenberndt
Revert "feat(custom icon) (#137)"
9ca5be5 
This reverts commit 38d1e2d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hrescak hrescak Awaiting requested review from hrescak

@kuldar kuldar Awaiting requested review from kuldar

@nikolasburk nikolasburk Awaiting requested review from nikolasburk

2 more reviewers

@janpio janpio janpio approved these changes

@2color 2color 2color approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Beta 6

Development

Successfully merging this pull request may close these issues.

Custom icon for .prisma files

4 participants

@carmenberndt @janpio @hrescak @2color