Skip to content

feat: custom icon for .prisma files#1263

Merged
Jolg42 merged 2 commits intomainfrom
feat/theming-icon
Oct 17, 2022
Merged

feat: custom icon for .prisma files#1263
Jolg42 merged 2 commits intomainfrom
feat/theming-icon

Conversation

@Druue
Copy link
Copy Markdown
Contributor

@Druue Druue commented Oct 13, 2022

closes #5

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 13, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 13, 2022

🤖 Pull request artifacts

file commit
pr1263-prisma.vsix 9147429

github-actions Bot added a commit that referenced this pull request Oct 13, 2022
@github-actions
Copy link
Copy Markdown

@Druue Druue requested a review from Jolg42 October 14, 2022 07:13
@Druue Druue added the kind/feature A request for a new feature. label Oct 14, 2022
Copy link
Copy Markdown
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Screenshot 2022-10-14 at 10 02 05

Thanks for the PR @Druue

@Jolg42 Jolg42 added this to the 4.5.0 milestone Oct 14, 2022
Copy link
Copy Markdown
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, my previous comment showed the icon from Seti theme (default)

Installing a random file icon theme shows this
Screenshot 2022-10-14 at 10 06 53

Let's use the same icon as Seti theme and then we can merge

@Jolg42
Copy link
Copy Markdown
Contributor

Jolg42 commented Oct 14, 2022

github-actions Bot added a commit that referenced this pull request Oct 17, 2022
Copy link
Copy Markdown
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

✅ First PR in language-tools 🥳

@Jolg42 Jolg42 merged commit a9abd0d into main Oct 17, 2022
@Jolg42 Jolg42 deleted the feat/theming-icon branch October 17, 2022 09:07
@Druue Druue requested a review from Jolg42 October 17, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature A request for a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom icon for .prisma files

3 participants