fix(engines): add nft annotation for libquery_engine#6
Merged
Conversation
williamluke4
force-pushed
the
nft/libquery_engine
branch
from
0d7b6e4 to
b2c9e6c
Compare
Jolg42
reviewed
Mar 1, 2021
| import { download } from '@prisma/fetch-engine' | ||
| import { enginesVersion } from "@prisma/engines-version"; | ||
| import { download } from "@prisma/fetch-engine"; | ||
| import path from "path"; |
Contributor
There was a problem hiding this comment.
Not sure why the double quotes and ; made it here.
Would be good to have the same setting as here https://github.com/prisma/prisma/blob/master/src/.prettierrc.yml
Author
There was a problem hiding this comment.
Yeah prettier just needs to be setup. I Will add that in this PR
Contributor
|
Should we merge this today? |
Author
|
As napi won't be in this release, it's not necessary to merge today
|
Jolg42
approved these changes
Mar 2, 2021
Contributor
Jolg42
left a comment
Jolg42
left a comment
There was a problem hiding this comment.
Thanks for adding Prettier ❤️
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.