Skip to content

Conversation

@janpio
Copy link
Contributor

@janpio janpio commented Jun 22, 2023

Depends on prisma/prisma#20417

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 1:02pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

@github-actions
Copy link
Contributor

This PR probably requires the following redirects to be added to vercel.json:

  • This PR does not change any pages in a way that would require a redirect.

@janpio janpio requested review from jharrell and ruheni July 27, 2023 10:23
@janpio janpio marked this pull request as ready for review July 27, 2023 10:23
@janpio janpio added this to the 5.1.0 milestone Jul 28, 2023
Copy link
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good.
I think it would be good to mention that directUrl is only supported for prisma studio since 5.1.0

| `provider` | **Yes** | String (`postgresql`, `mysql`, `sqlite`, `sqlserver`, `mongodb`, `cockroachdb`) | Describes which data source connectors to use. |
| `url` | **Yes** | String (URL) | Connection URL including authentication info. Most connectors use [the syntax provided by the database](/reference/database-reference/connection-urls#format). |
| `shadowDatabaseUrl` | No | String (URL) | Connection URL to the shadow database used by Prisma Migrate. Allows you to use a cloud-hosted database as the shadow database. |
| `directUrl` | No | String (URL) | Connection URL for [direct connection to the database](/data-platform/data-proxy/prisma-cli-with-data-proxy#set-a-direct-database-connection-url-in-your-prisma-schema).<br /><br />If you use a connection pooler URL in the `url` argument (for example, if you use the Data Proxy or pgBouncer), Prisma CLI commands [that require a direct connection to the database](/data-platform/data-proxy/prisma-cli-with-data-proxy#prisma-cli-commands-that-require-a-direct-database-connection) use the URL in the `directUrl` argument. <br/> <br/> The `directUrl` property is supported by Prisma Studio from version 5.1.0 upwards. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jolg42, Let me know if this captures your suggestion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but what about content/800-data-platform/050-data-proxy/700-prisma-cli-with-data-proxy.mdx? Because it actually is more valuable there, as we tell users that prisma studio "require a direct connection:".
And would not work with an earlier version.
Screenshot 2023-07-31 at 14 44 43

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. I've added a note on that page

@nikolasburk nikolasburk merged commit b0d2850 into main Aug 1, 2023
@nikolasburk nikolasburk deleted the janpio/studio-directurl branch August 1, 2023 12:56
ankur-arch pushed a commit that referenced this pull request Aug 10, 2023
Co-authored-by: ruheni <[email protected]>
Co-authored-by: Alex Ruheni <[email protected]>
Co-authored-by: Nikolas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants