Create bare-bones pull request template#708
Conversation
This template almost certainly needs fleshing out, but I figured a good place to start was making sure people run tests and making sure they update the Changelog.
|
For organization's sake you may want to move this (and other GitHub-specific templates) into a |
JHilker
left a comment
JHilker
left a comment
There was a problem hiding this comment.
Thanks for adding this. 🙇
Didn't even think of updating the changelog in my earlier PR
| @@ -0,0 +1,4 @@ | |||
| - [ ] Run tests | |||
| - [ ] Update the [`Changelog.md`][1] with a summary of your changes | |||
There was a problem hiding this comment.
Nit: Might as well reference it as CHANGELOG.md to prevent any file case confusion?
|
@JHilker you may also want to think about issue templates: https://help.github.com/articles/creating-issue-templates-for-your-repository/ |
|
Thanks, we should add that folder to https://github.com/prettier/prettier-vscode/blob/master/.vscodeignore I'll do it |
* Support prettier 1.17 * Update in reaction to new VS code feature to prompt when multiple formatters are installed * Support Prettier <1.8.0 for getSupportInfo (#707) * feat: hide statusBarItem for disabled languages (#733) * Resolve prettier to bundled if findPkg can't find it (#811) Fixes #522 Slightly different implementation of #561 * Update .vscodeignore Add .github folder * Create bare-bones pull request template (#708) * Create bare-bones pull request template This template almost certainly needs fleshing out, but I figured a good place to start was making sure people run tests and making sure they update the Changelog. * Create separate .github folder for issue/pr templates * add support for quoteProps * Support prettier 1.17 * Update in reaction to new VS code feature to prompt when multiple formatters are installed * add support for quoteProps
4 participants
This template needs fleshing out, but I figured a good place to start was making sure people run tests and making sure they update the Changelog.
Here's some background on Issue Templates and Pull Request Templates.