Skip to content

fix: Format vscode-userdata files. Fixes #2226#2648

Merged
ntotten merged 4 commits intoprettier:mainfrom
Antyos:antyos/format-vscode-userdata-2226
Aug 20, 2022
Merged

fix: Format vscode-userdata files. Fixes #2226#2648
ntotten merged 4 commits intoprettier:mainfrom
Antyos:antyos/format-vscode-userdata-2226

Conversation

@Antyos
Copy link
Copy Markdown
Contributor

@Antyos Antyos commented Jul 28, 2022

  • Run tests
  • Update the CHANGELOG.md with a summary of your changes

I tried running the tests in the Docker container, but I kept getting: warning [email protected]: The engine "vscode" appears to be invalid and it seemed like libraries were missing when trying to run the test VS Code. I have no clue. I tried. I only changed one line of code so it's probably ok?

Files with the scheme vscode-userdata, such as the user settings.json (found here on Windows: C:\Users\Andrew\AppData\Roaming\Code\User\settings.json) are no longer considered virtual so they can use a .prettierrc file for configuration.

A potential concern here is that I do now know what other files are considered vscode-userdata; I haven't been able to find any documentation about it. I'm not sure if making this change would have negative effects on other internal files.

Fixes: #2226.

@auto-assign auto-assign Bot requested a review from ntotten July 28, 2022 19:24
@Antyos Antyos changed the title fix: format vscode-userdata files. #2226 fix: Format vscode-userdata files. Fixes #2226 Jul 28, 2022
@ntotten ntotten merged commit 1b7e051 into prettier:main Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't find .prettierrc file when formatting settings.json on Windows.

2 participants