Preserve indentation when formatting selection#113
Merged
CiGit merged 2 commits intoprettier:masterfrom Jun 2, 2017
Merged
Conversation
This fixes prettier#109 by using the new `rangeStart` and `rangeEnd` options in Prettier v1.4.0 (see here for details: prettier/prettier#1609)
CiGit
reviewed
Jun 2, 2017
| fullDocumentRange(document), | ||
| format(document.getText(), document.fileName, { | ||
| rangeStart: document.offsetAt(range.start), | ||
| rangeEnd: document.offsetAt(range.end) |
Member
There was a problem hiding this comment.
Ahah. That was the range to 0 based function you told me in your PR 👍
Contributor
Author
There was a problem hiding this comment.
Yup, and there's also positionAt for going the other way.
Member
|
I should use the word soon more often #109 |
Contributor
Author
|
Haha, thanks for the quick merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #109 by using
the new
rangeStartandrangeEndoptions in Prettier v1.4.0 (see herefor details: prettier/prettier#1609)