This repository was archived by the owner on Apr 17, 2023. It is now read-only.
fix(prettierignore): properly ignore files again#447
Merged
Conversation
robwise
force-pushed
the
rob/prettierignore-hotfix
branch
from
831a9f3 to
e5a524f
Compare
robwise
changed the title
robwise
force-pushed
the
rob/prettierignore-hotfix
branch
from
e5a524f to
b5dd969
Compare
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
==========================================
+ Coverage 73.58% 73.75% +0.17%
==========================================
Files 29 29
Lines 458 461 +3
Branches 46 46
==========================================
+ Hits 337 340 +3
Misses 103 103
Partials 18 18
Continue to review full report at Codecov.
|
robwise
force-pushed
the
rob/prettierignore-hotfix
branch
from
b5dd969 to
dd4c849
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #404 changed to using Prettier's
getFileInfoandresolveConfigfunctions to determinewhether a file is formattable. We were not correctly invoking the API for
getFileInfoso everyfile was coming up as not ignored.
Fixes #446