Skip to content

Add test to confirm a bug in third-party.js is fixed#8837

Merged
fisker merged 3 commits intoprettier:masterfrom
fisker:issue-8815
Aug 1, 2020
Merged

Add test to confirm a bug in third-party.js is fixed#8837
fisker merged 3 commits intoprettier:masterfrom
fisker:issue-8815

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Jul 26, 2020

Fixes #8815

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker changed the title Build: Fix third-party bundle Add test to confirm a bug in third-party.js is fixed Jul 26, 2020
@fisker fisker marked this pull request as ready for review July 26, 2020 01:59
@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jul 26, 2020

This issue not exists on master.

Copy stable version third-party.js to run test, commit

We got the failed result, log on ci.

Should be a rollup issue.

@fisker fisker merged commit bf9974b into prettier:master Aug 1, 2020
@fisker fisker deleted the issue-8815 branch August 1, 2020 23:05
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON Error in .prettierrc.json: LinesAndColumns$1 is not a constructor

2 participants