Skip to content

SCSS: Fix Comments at the end of the file were lost if the final semicolon was omitted#8675

Merged
fisker merged 4 commits intoprettier:masterfrom
fisker:issue-8674
Jul 14, 2020
Merged

SCSS: Fix Comments at the end of the file were lost if the final semicolon was omitted#8675
fisker merged 4 commits intoprettier:masterfrom
fisker:issue-8674

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Jun 30, 2020

Fixes #8674

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker force-pushed the issue-8674 branch 2 times, most recently from 0f021bc to 581b721 Compare June 30, 2020 11:58
@fisker fisker marked this pull request as ready for review June 30, 2020 11:58
fisker
fisker commented Jun 30, 2020
View reviewed changes
Comment thread tests/scss/no-semicolon/__snapshots__/jsfmt.spec.js.snap
Comment on lines +65 to +66
@import ur
l(; //fonts.googleapis.com/css?family=Open+Sans:400,400italic);
Copy link
Copy Markdown
Member Author

@fisker fisker Jun 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually invalid code, so I guess it's ok to format like this.

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jul 1, 2020

Thank you!

@fisker fisker changed the title SCSS: Fix missing trailing comment when omit semicolon SCSS: Fix Comments at the end of the file were lost if the final semicolon was omitted Jul 1, 2020
@fisker fisker merged commit c0abefb into prettier:master Jul 14, 2020
@fisker fisker deleted the issue-8674 branch July 14, 2020 15:36
@adalinesimonian adalinesimonian mentioned this pull request Jun 9, 2021
Closed
3 tasks
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thorn0 thorn0 thorn0 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SCSS: unexpected format

3 participants

@fisker @thorn0 @alexander-akait