Skip to content

Run verify test on disabled babel-ts tests #7786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thorn0 merged 2 commits into from
Mar 18, 2020
Merged

Run verify test on disabled babel-ts tests #7786

thorn0 merged 2 commits into from
Mar 18, 2020

Conversation

@fisker
Copy link
Member

@fisker fisker commented Mar 18, 2020 •
edited
Loading

Refactor disabled babel-ts tests to a better way to manage.

Seems there is already a fixture fixed see 95edf2e

Run verify test on disabled babel-ts tests, make sure they throws SyntaxError

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker mentioned this pull request Mar 18, 2020
Merged
4 tasks
@fisker fisker force-pushed the disable-babel-ts-refactor branch from a3433bc to e3a9fa8 Compare March 18, 2020 04:49
thorn0
thorn0 reviewed Mar 18, 2020
View reviewed changes
@fisker fisker force-pushed the disable-babel-ts-refactor branch from e3a9fa8 to a8b3b0d Compare March 18, 2020 08:42
@fisker fisker changed the title Refactor disabled babel-ts tests Run verify test on disabled babel-ts tests Mar 18, 2020
@fisker fisker force-pushed the disable-babel-ts-refactor branch from a8b3b0d to f7ed703 Compare March 18, 2020 08:46
@fisker fisker force-pushed the disable-babel-ts-refactor branch from 6a1407b to dabd83f Compare March 18, 2020 11:00
@thorn0 thorn0 merged commit c82ce65 into prettier:next Mar 18, 2020
@fisker fisker deleted the disable-babel-ts-refactor branch March 18, 2020 13:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thorn0 thorn0 thorn0 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker @thorn0