Skip to content

Conversation

@fisker
Copy link
Member

@fisker fisker commented Feb 8, 2020

Fixes #7055 (Can't link issue, maybe need close it manually)

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker changed the base branch from dependabot/npm_and_yarn/next/flow-parser-0.118.0 to next February 8, 2020 22:06
@j-f1
Copy link
Member

j-f1 commented Mar 5, 2020

What’s the status of this?

# Conflicts:
#	tests_config/run_spec.js
@fisker fisker force-pushed the test-deep-compare branch from b0496a9 to f96d04b Compare March 8, 2020 18:56
@fisker
Copy link
Member Author

fisker commented Mar 10, 2020

@j-f1 need fix bugs

@j-f1
Copy link
Member

j-f1 commented Mar 11, 2020

Do you want to try to fix all the idempotency issues here or figure out a way to ignore them and make an issue about it?

@fisker
Copy link
Member Author

fisker commented Mar 11, 2020

I don't think we can fix all issues here. I've opened #7745 and #7746 , we can

  1. fix the failed tests first then enable this test
  2. ignore them and fix later

@j-f1
Copy link
Member

j-f1 commented Mar 11, 2020

How about gating the reformat test behind an env variable, then only enabling it for one run? (i.e. create a new job that only runs on Node 13 in dev mode and tests the second format) You could set its continue-on-error attribute to true so CI will still be green.

@thorn0
Copy link
Member

thorn0 commented Mar 11, 2020

I think better to add an option to run_spec to disable this check for specific tests, like I did with the disableBabelTS option.

@fisker
Copy link
Member Author

fisker commented Mar 11, 2020

We have filename, we can just simply list those failed files, and fix them later.

I'm AFK now, feel free to take over.

@fisker fisker force-pushed the test-deep-compare branch from 4feec50 to 93e0f1b Compare March 12, 2020 02:09
@fisker fisker force-pushed the test-deep-compare branch from 631d232 to bd46d79 Compare March 12, 2020 03:15
@fisker fisker changed the title [WIP] Test second format Test second format Mar 12, 2020
@fisker fisker marked this pull request as ready for review March 12, 2020 03:27
@fisker
Copy link
Member Author

fisker commented Mar 18, 2020

@j-f1 I can't request review from this PR, so friendly ping.

@lydell
Copy link
Member

lydell commented Mar 21, 2020

Oh, wow. Having tests for second format is going to be so good! 👏

@thorn0 thorn0 merged commit 71b2d35 into prettier:next Mar 21, 2020
@fisker fisker deleted the test-deep-compare branch March 21, 2020 13:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants