-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Test second format #7565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test second format #7565
Conversation
|
What’s the status of this? |
# Conflicts: # tests_config/run_spec.js
b0496a9 to
f96d04b
Compare
|
@j-f1 need fix bugs |
|
Do you want to try to fix all the idempotency issues here or figure out a way to ignore them and make an issue about it? |
|
How about gating the reformat test behind an env variable, then only enabling it for one run? (i.e. create a new job that only runs on Node 13 in dev mode and tests the second format) You could set its |
|
I think better to add an option to |
|
We have filename, we can just simply list those failed files, and fix them later. I'm AFK now, feel free to take over. |
4feec50 to
93e0f1b
Compare
631d232 to
bd46d79
Compare
|
@j-f1 I can't request review from this PR, so friendly ping. |
|
Oh, wow. Having tests for second format is going to be so good! 👏 |
Fixes #7055 (Can't link issue, maybe need close it manually)
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨