Conversation
bakkot
force-pushed
the
generator-star
branch
from
dbc4e7d to
011983a
Compare
bakkot
force-pushed
the
generator-star
branch
from
011983a to
8c17b90
Compare
alexander-akait
requested changes
Feb 3, 2020
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Please do not send PR before it was resolved, It will not be merged anyway until everyone comes to a common point of view
Collaborator
Author
Oh, sorry. When did that policy change? It used to be that we'd make PRs whenever something was being considered, and just not merge it until there was agreement. |
Member
|
@bakkot You can still do it, but it does not make sense, it is not a difficult change, so I would prefer not to waste time until there is a final solution, just my recommendation |
thorn0
force-pushed
the
generator-star
branch
from
8c17b90 to
641e06b
Compare
Because the release blog post will be generated from these files.
glen-84
reviewed
Feb 14, 2020
Merged
alexander-akait
approved these changes
Feb 18, 2020
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial revert of #3903. That PR also included an unrelated change to the spacing of the
*used for generator declarations andyield*, after very brief discussion in #7028, which this PR reverts (so that they are spelledfunction*andyield*, rather thanfunction *andyield *).This is, of course, just a style preference. But generally speaking I think prettier shouldn't change things which there is broad agreement on without extremely good reason, and here it looks to me like there was broad agreement on the previous style: see earlier discussion in the thread preceding #3903. I assume this discussion was missed when #7028 was being considered.
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨