Fix prefer-object-spread in /website
#7338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
Jan 15, 2020
thorn0
reviewed
Jan 15, 2020
| const rest = { ...this.props }; | ||
| delete rest.children; | ||
| delete rest.copy; | ||
|
|
Member
There was a problem hiding this comment.
const { children, copy, ...rest } = this.props;
fisker
commented
Jan 15, 2020
Comment on lines
+28
to
+30
| no-unused-vars: | ||
| - error | ||
| - ignoreRestSiblings: true |
sosukesuzuki
approved these changes
Jan 15, 2020
Member
Author
|
You guys prefer const { children, copy, ...rest } = this.props;or const { children, copy: _, ...rest } = this.props;? In this case |
Member
|
Looks better: const { children, copy, ...rest } = this.props; |
Member
Author
|
better, but second can tell |
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨