Use array destructuring for some simple case #7330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
Jan 15, 2020
jamesgeorge007
suggested changes
Jan 15, 2020
Contributor
jamesgeorge007
left a comment
jamesgeorge007
left a comment
There was a problem hiding this comment.
Left couple of comments.
src/document/doc-printer.js
Outdated
| const ind = x[0]; | ||
| const mode = x[1]; | ||
| const doc = x[2]; | ||
| const [ind, mode, doc] = x; |
Contributor
There was a problem hiding this comment.
Suggested change
| const [ind, mode, doc] = x; | |
| const [ind, mode, doc] = cmds.pop(); |
Contributor
There was a problem hiding this comment.
I can't see the variable x serving it's purpose anywhere else.
Member
Author
There was a problem hiding this comment.
Good idea, updated. Thanks!
Member
|
I'm really not sure the readability improves in simple cases like this (with only one variable declared): - const child = node.children[0];
+ const [child] = node.children;Let's keep them as is. |
fisker
force-pushed
the
style/array-destructuring
branch
from
a3380b6 to
cfcbdaf
Compare
jamesgeorge007
approved these changes
Jan 15, 2020
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨