-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
refactor css comments #7021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor css comments #7021
Conversation
6f68971 to
900f9f0
Compare
|
@thorn0 done 👍 |
|
@evilebottnawi The tests seem to be failing |
|
@lydell nothing new in PR) keep in todo for investigation |
|
If it's an urgent fix, you can simply use |
|
Let's do it for next, it is not high priority |
900f9f0 to
d069fec
Compare
71940c0 to
d33409f
Compare
|
Ready for review. (update - this is SOLVED) Known issue: quotes are stripped from inline comments in values. Difficult to fix because Prettier pr-7021 --parser lessInput: a {
opacity: // "!"
1;
}Output: a {
opacity: // !
1;
}
|
|
@thorn0 sounds good, let's open a issue after merge |
|
Would it be possible to replace quotes in comments with some placeholder and then replace back to quotes at the end? |
|
This placeholder has to be one character long. E.g. we could use |
|
Yeah, why not. I think it’s more likely that people put quotes in their comments than |
32ddbc3 to
d97b342
Compare
sosukesuzuki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with CSS and LESS, but looks very good to me.
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨
fixes #7780