Fix new usage for builtin objects
#6968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
changed the title
new usage for builtin typesnew usage for builtin objects
Member
Author
|
question: keep the rule? |
alexander-akait
approved these changes
Nov 16, 2019
sosukesuzuki
approved these changes
Nov 16, 2019
lydell
reviewed
Nov 16, 2019
| const WIDTH = columns - stringWidth(OK) + 1; | ||
| if (input.length < WIDTH) { | ||
| input += Array(WIDTH - input.length).join(chalk.dim(".")); | ||
| input += new Array(WIDTH - input.length).join(chalk.dim(".")); |
Member
There was a problem hiding this comment.
We could also change stuff like this into .repeat on the next branch.
Member
There was a problem hiding this comment.
/cc @fisker if you’re looking for more refactoring to do :)
lydell
approved these changes
Nov 16, 2019
Member
|
Maybe it’s going to be easier to merge all the eslint-plugin-unicorn PRs into |
Member
|
@lydell why? It is not breaking change 😄 |
Member
|
I thought about merge conflicts. If we merge this to master and then replace |
Member
|
@lydell it makes sense 👍 |
sosukesuzuki
pushed a commit
to sosukesuzuki/prettier
that referenced
this pull request
Jan 2, 2020
lipis
added a commit
that referenced
this pull request
Jan 8, 2020
* 'next' of github.com:prettier/prettier: Optimize some usage of `Array#filter` (#6996) Update `jest` to v24 (#6954) Replace `trim{Left,Right}` with `trim{Start,End}` (#6994) Set `trailingComma` default value to `es5` (#6963) Fix `new` usage for builtin objects (#6968) Replace `indexOf` with `includes` (#6967) fix: tests for empty type parameters in TS (#6960) Fix MDX html parsing errors (#6949) fix: issue #6813 (Zero-based lists are broken) (#6852) Style: use async functions (#6935) Disable trailingComma for Angular internal parser (#6912) Update `snapshot-diff` to v0.6.1 (#6955) Update build scripts to target Node.js 10 (#6908)
4 tasks
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨