Support string-to-package config in JSON schema: #6941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prettier supports having just a string in the config file to use a
shared config from a package. Example:
"@company/prettier-config"
But the JSON schema generated by running `node
scripts/generate-schema.js` did not include that possibility.
See SchemaStore/schemastore#855 for more
information.
Member
|
Can we add test? |
Member
|
There already exists a test for this in |
alexander-akait
approved these changes
Nov 13, 2019
lipis
added a commit
that referenced
this pull request
Jan 8, 2020
* 'master' of github.com:prettier/prettier: Don't lowercase element names in CSS selectors (#6947) Support string-to-package config in JSON schema: (#6941) Rename SECURITY.md to .github/SECURITY.md Create SECURITY.md Add the XML plugin to the docs (#6944) TypeScript: Fix formatting of type operators as arrow function… (#6901) SCSS: don't add extra comma after last comment in map (#6918) Remove typescript-etw from build (#6919)
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier supports having just a string in the config file to use a
shared config from a package. Example:
But the JSON schema generated by running
node scripts/generate-schema.jsdid not include that possibility.See SchemaStore/schemastore#855 for more
information.