Remove typescript-etw from build #6919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
approved these changes
Nov 11, 2019
Member
|
@nickmccurdy since |
Member
Author
|
What should the test do, just import everything and assert there are no warnings? |
thorn0
approved these changes
Nov 11, 2019
Member
|
maybe something like this webpack({
entry: './parser-typescript.js',
mode: 'production'
}, (error, stats) => {
// check error and stats
})quick test wget https://unpkg.com/[email protected]/parser-typescript.js
node -e "require('webpack')({entry: './parser-typescript.js', mode: 'production'}, (error, stats) => console.error(stats.compilation.warnings))" |
Member
Author
|
Thanks. I understand your test example, but where should I put this test? Test files? Integration test files (don't seem to run in CI)? After |
j-f1
approved these changes
Nov 11, 2019
alexander-akait
approved these changes
Nov 12, 2019
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
I think manual tests enough in this case
Merged
lipis
added a commit
that referenced
this pull request
Jan 8, 2020
* 'master' of github.com:prettier/prettier: Don't lowercase element names in CSS selectors (#6947) Support string-to-package config in JSON schema: (#6941) Rename SECURITY.md to .github/SECURITY.md Create SECURITY.md Add the XML plugin to the docs (#6944) TypeScript: Fix formatting of type operators as arrow function… (#6901) SCSS: don't add extra comma after last comment in map (#6918) Remove typescript-etw from build (#6919)
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6903 (tested with
yarn linkand webpack)Thanks to @j-f1 for figuring out the fix
docs/directory) (N/A)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md. (N/A)✨Try the playground for this PR✨